Skip to content

Conversation

@Shane32
Copy link
Owner

@Shane32 Shane32 commented Apr 2, 2024

Summary

  • Fixes GitHub Action workflows.
  • Removes ifdef for hashes on NETFX. Not sure why they were there, but tests fail unless they are removed, both locally and within CI.


- name: Install additional .NET SDKs
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
Copy link
Owner Author

@Shane32 Shane32 Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, I've had numerous problems with actions/setup-dotnet on other GitHub workflows that are still using v1; bumping to v4 has fixed those problems for me in the past.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, then let's use v4. I just ised v1 because it was the up-to-date version when setting up the workflow.

@codebude
Copy link
Collaborator

codebude commented Apr 2, 2024

Summary

  • Removes ifdef for hashes on NETFX. Not sure why they were there, but tests fail unless they are removed, both locally and within CI.

Full explanation why the ifdef was used: #455
But since I also can't replicate the behaviour (there might have been a change anywhere down the PNG encoder lane), I'm fine with removing them.

@codebude codebude merged commit dfa5209 into Shane32:master Apr 2, 2024
@Shane32 Shane32 deleted the fix_workflows branch April 2, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants