-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(chips): allow to specify md-max-chips attribute through md-contacts #10827
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Thank you for your contribution! Please follow the commit message guidelines. |
Splaktar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a unit test to verify this functionality?
|
There were some issues with this PR that I have resolved in PR #12050. |
Hi,
We would need for a limit of the number of contacts. Could we pass the md-max-chips options from md-contacts to md-chips the same way than other options?
Sub-question: could it be tagged as a patch version?
Thanks,