Impossible to merge works - web client should respect rate limits

[tfmorris]

Problem

As increasingly aggressive rate limits have been enforced the web client hasn't been updated to respect those rate limits, making certain resource intensive operations, like the merge works screen rendering, impossible, even though they only represent a single user action.

This work merge:

https://openlibrary.org/works/merge?records=OL19883941W,OL18180666W,OL34839204W,OL31196671W,OL18964368W,OL19169319W,OL19025821W,OL18196302W,OL18674587W,OL18968678W,OL19479057W,OL18563718W,OL19600006W,OL19355339W,OL29309676W,OL25045090W,OL34963883W

causes an alert popup saying "Click OK to retry" which, of course, is exactly the wrong thing to do since it'll only dig the hole deeper.

Reproducing the bug

1. Go to ...
2. Do ...

• Expected behavior: Web client backs off when it gets a rate limit exceeded error and retries the operation at the specified future time. If this is impossible for some reason, at least stop, warn the user, and let them manually retry the operation.

• Actual behavior: Page rendering fails over and over without any indication to the user as to whats happening.

Context

• Browser (Chrome, Safari, Firefox, etc):
• OS (Windows, Mac, etc):
• Logged in (Y/N): Y
• Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

• [ ]

Related files

Stakeholders

---

Instructions for Contributors

• Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

[cdrini]

Switched the limit back to be per-minute; it should be working now 👍

[tfmorris]

This merge still fails for me. There doesn't seem to be any handling of the 429 response in the web client (although it also doesn't look like any Retry-After or other hints are being returned either)

https://openlibrary.org/works/merge?records=OL8165007W,OL40238737W,OL41668313W,OL40423432W,OL30620069W,OL8367359W,OL40692889W,OL41135652W,OL40535436W,OL41712811W,OL41738078W,OL30660386W,OL41247566W,OL41401280W,OL40956554W,OL10009799W,OL40000586W,OL9878621W

Hmmm, looks like I don't have permission to reopen my own issue? I guess I have to create a new one.