Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • it styles nested md-tabs as well as itself

Issue Number:
Fixes #10541

What is the new behavior?

  • md-align-tabs only styles the current component

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- it was styling nested `md-tabs` as well

Fixes #10541
@Splaktar Splaktar added this to the 1.2.2 milestone Oct 25, 2020
@Splaktar Splaktar self-assigned this Oct 25, 2020
@google-cla google-cla bot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Oct 25, 2020
@Splaktar Splaktar requested a review from annieyw October 25, 2020 00:18
@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. type: bug ui: CSS pr: merge ready This PR is ready for a caretaker to review labels Oct 25, 2020
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Oct 26, 2020
@Splaktar Splaktar merged commit d77fbc4 into master Oct 26, 2020
@Splaktar Splaktar deleted the tabs-align-bottom-styles branch October 26, 2020 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ui: CSS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tabs: nested inside md-tabs with md-align-tabs="bottom"

2 participants