feat(tests): add comprehensive tests for KV storage plugin #1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive test suite for the KV storage plugin, ensuring that CRUD operations, transactions, concurrency, edge cases, and pagination are thoroughly verified.
- Adds multiple configurations for different databases (MySQL, PostgreSQL, SQLite) using Docker for image-based tests
- Implements global setup and teardown routines for test data source initialization and resource cleanup
- Covers diverse test cases including basic operations, transaction handling, boundary conditions, and stress testing
| dbSetting = dbSettingMapping[string(schemas.SQLITE)] | ||
| } | ||
| if dbSetting.Driver == string(schemas.SQLITE) { | ||
| os.RemoveAll(dbSetting.Connection) |
There was a problem hiding this comment.
[nitpick] Consider using os.Remove instead of os.RemoveAll for SQLite file removal, as the cleanup function later uses os.Remove. This change would improve consistency in how temporary files are deleted.
Suggested change
| os.RemoveAll(dbSetting.Connection) | |
| os.Remove(dbSetting.Connection) |
LinkinStars
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds complete test suite for KV storage plugin covering CRUD operations, transactions, concurrency, and edge cases.
What's Added