Fix error with Boost::headers when building with Thrift #48852
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When I tried to build arrow with bundled Thrift enabled with Boost installed in a system it always fails with an error like following:
As I found out it happens because the
Boost::headersis not properly linked to the thrift library so it could be linked as a transitive dependency when it's built by the project .What changes are included in this PR?
headersto theARROW_BOOST_COMPONENTSincpp/cmake_modules/ThirdpartyToolchain.cmake;Boost::headersin thebuild_thriftfunction incpp/cmake_modules/ThirdpartyToolchain.cmake.Are these changes tested?
Yes.
Are there any user-facing changes?
No.