Skip to content

Conversation

@wankai123
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wankai123 wankai123 added this to the 10.4.0 milestone Jan 12, 2026
@wankai123 wankai123 added the bug Something isn't working and you are sure it's a bug! label Jan 12, 2026
Fine0830
Fine0830 previously approved these changes Jan 12, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses the issue of non-unique IDs generated by browser scripts by having the OAP Server generate UUIDs server-side instead of relying on client-side generated IDs for BrowserErrorLog entries.

Changes:

  • Modified BrowserErrorLogDecorator.getUniqueId() to generate a server-side UUID instead of using the client-provided ID
  • Updated the CHANGES.md documentation to reflect this modification
  • Updated the apm-network subproject commit reference

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
BrowserErrorLogDecorator.java Replaced client-side ID retrieval with server-side UUID generation to ensure global uniqueness
changes.md Added changelog entry documenting the UUID generation change and fixed a missing period
apm-network/src/main/proto Updated subproject commit reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wu-sheng
wu-sheng previously approved these changes Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working and you are sure it's a bug!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants