Skip to content

feat(bin): Consensus Node #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
refcell merged 1 commit into from
Jan 14, 2026
Merged

feat(bin): Consensus Node #395

refcell merged 1 commit into from
Jan 14, 2026
+473 −103

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Jan 12, 2026 •
edited
Loading

Summary

This PR hooks up the base consensus node, wiring in all the CLI arguments from the client/cli crate.

Closes #376.

@refcell refcell added this to the v0.4.0 milestone Jan 12, 2026
@refcell refcell self-assigned this Jan 12, 2026
@refcell refcell added K-enhancement Kind: New feature or request F-do-not-merge Flag: don't merge until this label is removed. A-bin Area: binary related labels Jan 12, 2026
@refcell refcell changed the title feat(bin): kona consensus node feat(bin): Kona Consensus Node Jan 12, 2026
Base automatically changed from rf/consensus-bin to main January 12, 2026 23:00
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 12, 2026 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

This was referenced Jan 12, 2026
Merged
Merged
Closed
Closed
@refcell refcell force-pushed the rf/kona-consensus branch 3 times, most recently from 184ba44 to 3eff018 Compare January 13, 2026 15:04
This was referenced Jan 13, 2026
Closed
Merged
refcell added a commit that referenced this pull request Jan 13, 2026
@refcell
refactor(cli-utils): simplify RuntimeManager API
cc2acd7 
Consolidate runtime utilities by replacing separate build_runtime(),
run_until_ctrl_c(), and run_until_ctrl_c_fallible() methods with a
simpler tokio_runtime() and unified run_until_ctrl_c() that handles
runtime creation internally.

Ported from #395.
@refcell refcell mentioned this pull request Jan 13, 2026
Merged
@refcell refcell mentioned this pull request Jan 13, 2026
Merged
@refcell refcell mentioned this pull request Jan 13, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2026
@refcell
refactor(cli-utils): RuntimeManager API Updates (#418)
23ed22b 
* refactor(cli-utils): simplify RuntimeManager API

Consolidate runtime utilities by replacing separate build_runtime(),
run_until_ctrl_c(), and run_until_ctrl_c_fallible() methods with a
simpler tokio_runtime() and unified run_until_ctrl_c() that handles
runtime creation internally.

Ported from #395.

* fix(cli-utils): bias ctrl+c
@refcell refcell force-pushed the rf/kona-consensus branch 3 times, most recently from a6994e1 to 8149ba2 Compare January 14, 2026 02:19
@refcell refcell mentioned this pull request Jan 14, 2026
Merged
@refcell refcell force-pushed the rf/kona-consensus branch 5 times, most recently from 2b4bd7e to 2e439da Compare January 14, 2026 13:15
@refcell refcell mentioned this pull request Jan 14, 2026
Merged
@refcell refcell force-pushed the rf/kona-consensus branch 3 times, most recently from f6c1270 to f46b631 Compare January 14, 2026 15:03
This was referenced Jan 14, 2026
Merged
Merged
Merged
@refcell refcell force-pushed the rf/kona-consensus branch 2 times, most recently from 815d79e to 209f9d7 Compare January 14, 2026 22:14
@refcell refcell changed the base branch from main to port-pr-395-cli-changes January 14, 2026 22:14
@refcell refcell force-pushed the port-pr-395-cli-changes branch from 349d858 to 54118c4 Compare January 14, 2026 22:18
@refcell refcell marked this pull request as ready for review January 14, 2026 22:21
danyalprout
danyalprout previously approved these changes Jan 14, 2026
View reviewed changes
Base automatically changed from port-pr-395-cli-changes to main January 14, 2026 22:51
@refcell refcell dismissed danyalprout’s stale review January 14, 2026 22:51

The base branch was changed.

@refcell refcell removed the F-do-not-merge Flag: don't merge until this label is removed. label Jan 14, 2026
@refcell
feat(bin): kona consensus node
57e0b75 
rollup boost args

base prefixes

fixes
@refcell refcell requested a review from danyalprout January 14, 2026 22:58
@refcell refcell added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit 12f7da9 Jan 14, 2026
15 checks passed
@refcell refcell deleted the rf/kona-consensus branch January 14, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danyalprout danyalprout danyalprout approved these changes

Assignees

@refcell refcell

Labels

A-bin Area: binary related K-enhancement Kind: New feature or request

Projects

None yet

Milestone

v0.4.0

Development

Successfully merging this pull request may close these issues.

feat(bin): Minimal Base Consensus Binary

4 participants

@refcell @cb-heimdall @danyalprout