-
Notifications
You must be signed in to change notification settings - Fork 110
chore(builder): Fix priority fee ordering violations in flashblocks block building #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Heimdall Review Status
|
meyer9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd wait for one other reviewer, but this makes sense to me. Can you also open a PR/issue dependent on this one for removing this workaround? #375
refcell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but maybe it's worth making this configurable via an env var? This way it can be toggled off/on if needed?
|
@meyer9 just opened this issue, lmk if this makes sense |
refcell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks for adding the config option
We see a bunch of fee violation these days, from our internal monitoring and reported by others
There's a possible fix but not released yet (paradigmxyz/reth#19940) where blocked transactions break nonce chain tracking.
Rather than waiting for the official release (which requires baking and unsure about the release schedule), doing a workaround now is to check at the execution level for violation, and skip the txn when found
slack context: https://coinbase.slack.com/archives/C06RRAWRCTX/p1768415995939549?thread_ts=1768403579.942579&cid=C06RRAWRCTX