Skip to content

Conversation

@rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Jan 23, 2025

🗣 Description

The code changes made for this issue handle the case where the tenant has only the top orgunit - no sub-orgunits and no groups. It was discovered and reported by a user.

Closes #573

🧪 Testing

Tested internally via debugger, simulating that only the top-level orgunit existed without any sub-orgunits and groups.
The user who reported this issue also tested the proposed change and has confirmed that the changes resolve the issue.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev self-assigned this Jan 23, 2025
@rlxdev rlxdev added the bug This issue or pull request addresses broken functionality label Jan 23, 2025
Base automatically changed from 519-policy-api-updates to main February 5, 2025 19:43
@rlxdev rlxdev force-pushed the 573-no-groups-suborgunits branch from 7d60224 to c6aace9 Compare February 5, 2025 20:44
@rlxdev rlxdev marked this pull request as ready for review February 11, 2025 14:59
@rlxdev rlxdev added this to the Eel milestone Feb 11, 2025
@rlxdev rlxdev linked an issue Feb 11, 2025 that may be closed by this pull request
@rlxdev rlxdev added the eel label Feb 11, 2025
@buidav
Copy link
Collaborator

buidav commented Feb 12, 2025

@rlxdev Can you designate reviewers for this PR?

@prodjom prodjom requested review from adhilto, buidav and snarve February 13, 2025 16:15
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on a tenant with no custom OUs or groups: worked as expected. I also tested on a tenant with a custom group but no custom OUs: also worked as expected. Great work.

Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors from running this branch against our normal test tenants either.
Note that the smoke test for just mac? is failing because of #604.
Smoke test failure will be addressed once that issue is resolved.

@buidav buidav merged commit f664410 into main Feb 14, 2025
11 of 14 checks passed
@buidav buidav deleted the 573-no-groups-suborgunits branch February 14, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue or pull request addresses broken functionality eel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A group must exist for successful execution

5 participants