Skip to content

Conversation

@adhilto
Copy link
Collaborator

@adhilto adhilto commented Apr 10, 2025

🗣 Description

  • Update the Python code to enforce policy API dependencies
  • Update the Common Controls Rego code to define the dependencies.

💭 Motivation and context

Closes #663.
Closes #659.

📷 Screenshots (if appropriate)

Screenshot 2025-04-10 083823
Screenshot 2025-04-10 083804

🧪 Testing

I temporarily modified the policy API to randomly drop stuff:
image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass. [smoke test is still broken but it was broken before]

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added this to the Eel milestone Apr 10, 2025
@adhilto adhilto requested review from amart241 and rlxdev April 10, 2025 16:46
@adhilto adhilto self-assigned this Apr 10, 2025
@adhilto adhilto linked an issue Apr 10, 2025 that may be closed by this pull request
16 tasks
@adhilto adhilto force-pushed the 512-update-rego-prerequisites-for-policy-api branch from f7c5c59 to 03f63bd Compare April 11, 2025 21:02
Copy link
Collaborator

@rlxdev rlxdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simple wording change in a "temporary" comment.

Co-authored-by: Roy Lane <[email protected]>
@adhilto adhilto merged commit ef351fa into main Apr 21, 2025
10 of 11 checks passed
@adhilto adhilto deleted the 512-update-rego-prerequisites-for-policy-api branch April 21, 2025 18:22
This was referenced Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants