Remove flag_pattern_matching compatibility code

[Swatinem]

The Sentry message I introduced was never hit, so it is fair to say that we are not running into any incompatibility there.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.59%. Comparing base (9401035) to head (32a0b9a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   88.60%   88.59%   -0.01%     
==========================================
  Files         463      463              
  Lines       12773    12763      -10     
  Branches     1455     1453       -2     
==========================================
- Hits        11317    11307      -10     
  Misses       1151     1151              
  Partials      305      305              

Flag	Coverage Δ
shared-docker-uploader	88.59% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codspeed-hq]

CodSpeed Performance Report

Merging #604 will not alter performance

_{Comparing swatinem/no-flagpatterncompat (32a0b9a) with main (9401035)}

Summary

✅ 9 untouched benchmarks