Cg2: Add the ability to filter stats #387
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large user of this library (unsurprisingly) is the containerd daemon, and specifically through the CRI entrypoint. There's quite a few stats we gather that are never bubbled up the chain when requested through that funnel. The stats never used are:
MemoryEvents, Rdma, Hugetlb, and IO.
We should likely do the same to cg1 (#370), but if we want to add it to the Cgroup interface it'd be a breaking change.