Skip to content

Conversation

@michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Mar 7, 2023

What does this PR do?

Updates the python runtime under the release-typescript-models job from 3.9.2 to 3.9.12 due to the current being unsupported by the latest Ubuntu runner. Also updates setup-python to v4.

Which issue(s) does this PR fix

fixes #1048

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (04373ec) 35.64% compared to head (a9500e6) 35.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1051   +/-   ##
=======================================
  Coverage   35.64%   35.64%           
=======================================
  Files          52       52           
  Lines        6669     6669           
=======================================
  Hits         2377     2377           
  Misses       4147     4147           
  Partials      145      145           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, michael-valdron

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that the setup-python action is up to v4 now -- it may be worth updating that as well.

@openshift-ci openshift-ci bot removed the lgtm label Mar 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2023

New changes are detected. LGTM label has been removed.

@michael-valdron michael-valdron merged commit 9057a5d into devfile:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python runtime version for release-typescript-models is currently unsupported

2 participants