Skip to content

Conversation

@pinclau
Copy link
Member

@pinclau pinclau commented Jun 24, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 24, 2024

Qodana for PHP

57 new problems were found

Inspection name Severity Problems
Undefined class 🔶 Warning 42
Undefined namespace 🔶 Warning 13
Undefined method 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@alexmerlin alexmerlin linked an issue Jun 25, 2024 that may be closed by this pull request
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • src/Admin/src/Repository/AdminLoginRepository.php:
  • add use Frontend\Admin\Entity\AdminLogin;
  • add: #[Entity(AdminLogin::class)]

…e new dotkernel di package

Signed-off-by: Claudiu Pintiuta <[email protected]>
Signed-off-by: Claudiu Pintiuta <[email protected]>
Signed-off-by: Claudiu Pintiuta <[email protected]>
@codecov
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (5.0@797a241). Learn more about missing BASE report.

Files Patch % Lines
src/Setting/src/Controller/SettingController.php 0.00% 6 Missing ⚠️
src/App/src/Controller/PageController.php 0.00% 4 Missing ⚠️
src/Setting/src/Service/SettingService.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             5.0     #245   +/-   ##
======================================
  Coverage       ?   64.05%           
  Complexity     ?      347           
======================================
  Files          ?       49           
  Lines          ?     1764           
  Branches       ?        0           
======================================
  Hits           ?     1130           
  Misses         ?      634           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arhimede arhimede merged commit fb560ba into 5.0 Jun 26, 2024
@alexmerlin alexmerlin deleted the di-attributes branch June 27, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace annotation with atttributes

6 participants