Implemented doctrine enums #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
alexmerlin
requested changes
Mar 8, 2025
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
arhimede
approved these changes
Mar 11, 2025
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
alexmerlin
approved these changes
Mar 11, 2025
| } | ||
|
|
||
| if ($identityClass->$methodName() !== $option['value']) { | ||
| if ($identityClass->$methodName()->value !== $option['value']) { |
Member
There was a problem hiding this comment.
Suggested change
| if ($identityClass->$methodName()->value !== $option['value']) { | |
| if ($identityClass->$methodName() !== $option['value']) { |
We cannot force ->value on $methodName because this can be a getter on any property from the identity_class. We can still check status as long as we use the enum in the option value. See below example:
config/autoload/authentication.global.php:
'options' => [
'status' => [
'value' => \Admin\Admin\Enum\AdminStatusEnum::Active,
'message' => \Admin\App\Message::ADMIN_INACTIVE,
],
],| #[ORM\Column(name: 'password', type: 'string', length: 100)] | ||
| protected string $password; | ||
|
|
||
| #[ORM\Column( |
Member
There was a problem hiding this comment.
#[ORM\Column(type: 'admin_status_enum', options: ['default' => AdminStatusEnum::Active])]| columnDefinition: "ENUM('yes', 'no')" | ||
| )] | ||
| protected ?string $isMobile = null; | ||
| #[ORM\Column(type: 'yes_no_enum', nullable: true, enumType: YesNoEnum::class)] |
Member
There was a problem hiding this comment.
Suggested change
| #[ORM\Column(type: 'yes_no_enum', nullable: true, enumType: YesNoEnum::class)] | |
| #[ORM\Column(type: 'yes_no_enum', nullable: true)] |
|
|
||
| #[ORM\Column(name: "loginStatus", type: "string", nullable: true, columnDefinition: "ENUM('success', 'fail')")] | ||
| protected ?string $loginStatus = null; | ||
| #[ORM\Column(type: 'success_failure_enum', nullable: true, enumType: SuccessFailureEnum::class)] |
Member
There was a problem hiding this comment.
Suggested change
| #[ORM\Column(type: 'success_failure_enum', nullable: true, enumType: SuccessFailureEnum::class)] | |
| #[ORM\Column(type: 'success_failure_enum', nullable: true)] |
| self::ROLE_ADMIN, | ||
| self::ROLE_SUPERUSER, | ||
| ]; | ||
| #[ORM\Column( |
Member
There was a problem hiding this comment.
Suggested change
| #[ORM\Column( | |
| #[ORM\Column(type: 'admin_role_enum', options: ['default' => AdminRoleEnum::Admin])] |
| 'admins' => $result['rows'], | ||
| 'statuses' => Admin::STATUSES, | ||
| 'identifier' => Setting::IDENTIFIER_TABLE_ADMIN_LIST_SELECTED_COLUMNS, | ||
| 'statuses' => AdminStatusEnum::cases(), |
Member
There was a problem hiding this comment.
Suggested change
| 'statuses' => AdminStatusEnum::cases(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.