Skip to content

Conversation

@wralith
Copy link
Contributor

@wralith wralith commented Nov 24, 2022

  • My submissions follows the Submission Rules
  • I have read and accepted the Terms and Conditions

Feature: This PR adds postgres adapter for src/lib/data

Unimplemented Methods

find() and findAll(): I need more instruction on how you want them to work. Maybe additional type with filter conditions.

Behaviors

  • Opens new connection to db each request. Pool can be applied for improvement.
  • add, update and replace throws if param type does not match with table.

Assumptions

  • Table that match type T already created in the database.
  • Primary key of table is id

Introduced Dependencies

  • deno-postgres driver handling connection between code and database.
  • bld I couldn't find compatible query builder to use with deno-postgres and wrote simple one. Can be replaced if there are alternative to implement queries with generic data type.

Tests

  • I couldn't find a way to mock postgres in memory for deno, tests requires postgres container.
  • Not compatible with current CI flow. So marked to ignore in bdd.

@eser eser merged commit 62d50b6 into eser:development Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants