[camera_android_camerax] get camera name from Camera2CameraInfo.getCameraId in availableCameras #10775
+53
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request updates the availableCameras method to use the camera ID from Camera2CameraInfo.getCameraId as the camera name, which is a more stable identifier. The implementation change is correct, and the corresponding updates to the changelog, pubspec, and tests are mostly good. I've found one issue in the tests where a shared mock instance is being re-stubbed in a loop, which could lead to flaky tests. I've provided a suggestion to fix this by creating a new mock instance for each call.
camsim99
approved these changes
Jan 12, 2026
Contributor
camsim99
left a comment
There was a problem hiding this comment.
LGTM thanks for taking this on :)
Contributor
|
@jesswrd do you mind giving this a second review? |
jesswrd
approved these changes
Jan 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2026
…Info.getCameraId in availableCameras (flutter/packages#10775)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 13, 2026
flutter/packages@e57e7f4...eb9e1dc 2026-01-13 [email protected] [google_maps_flutter] Migrate iOS heatmaps to Pigeon (flutter/packages#10754) 2026-01-13 [email protected] Set Gemini Code Assist include_drafts to false (flutter/packages#10765) 2026-01-12 [email protected] [google_fonts] Update the font generator to exclude variable font entries when a static entry of the same weight and style exists (flutter/packages#10739) 2026-01-12 [email protected] [camera_android_camerax] get camera name from Camera2CameraInfo.getCameraId in availableCameras (flutter/packages#10775) 2026-01-12 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 7.0.0 to 8.0.0 in the all-github-actions group (flutter/packages#10773) 2026-01-12 [email protected] Roll Flutter from 3134be8 to d81cd3e (11 revisions) (flutter/packages#10779) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#147545
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3