-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix Waitlist button padding issue #11079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Waitlist button padding issue #11079
Conversation
…as a specification of cta-button-group in book.less; this change should make all paddings uniform.
|
@doct0r-furcation were you able to run this locally (or in gitpod) to see it working? If so, can you share a screenshot? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11079 +/- ##
==========================================
+ Coverage 17.14% 17.85% +0.71%
==========================================
Files 91 92 +1
Lines 4981 5096 +115
Branches 867 887 +20
==========================================
+ Hits 854 910 +56
- Misses 3588 3639 +51
- Partials 539 547 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Squash on merge, if possible please :) |
jimchamp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @doct0r-furcation! Everything is looking good on testing for all screen sizes.


Join waitlist had a padding error; i've added the join waitlist form as a specification of cta-button-group in book.less; this change should make all paddings uniform.
Issue #11036
Fix
Technical
The padding for all form buttons should be uniform after merging this fix.
Testing
Refer to #11036 (comment)
Screenshot
I am not entirely sure how to check the browser/UI implementation of the issue.
Stakeholders
@RayBB @mekarpeles