Skip to content

Conversation

@doct0r-furcation
Copy link
Contributor

@doct0r-furcation doct0r-furcation commented Jul 29, 2025

Join waitlist had a padding error; i've added the join waitlist form as a specification of cta-button-group in book.less; this change should make all paddings uniform.

Issue #11036

Fix

Technical

The padding for all form buttons should be uniform after merging this fix.

Testing

Refer to #11036 (comment)

Screenshot

I am not entirely sure how to check the browser/UI implementation of the issue.

Stakeholders

@RayBB @mekarpeles

…as a specification of cta-button-group in book.less; this change should make all paddings uniform.
@RayBB
Copy link
Collaborator

RayBB commented Jul 30, 2025

@doct0r-furcation were you able to run this locally (or in gitpod) to see it working? If so, can you share a screenshot?

@mekarpeles mekarpeles changed the title Join waitlist had a padding error; i've added the join waitlist form … Fix Waitlist button padding issue Aug 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.85%. Comparing base (e027195) to head (539c246).
⚠️ Report is 414 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11079      +/-   ##
==========================================
+ Coverage   17.14%   17.85%   +0.71%     
==========================================
  Files          91       92       +1     
  Lines        4981     5096     +115     
  Branches      867      887      +20     
==========================================
+ Hits          854      910      +56     
- Misses       3588     3639      +51     
- Partials      539      547       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mekarpeles
Copy link
Member

Before
image

After
image

@mekarpeles
Copy link
Member

Squash on merge, if possible please :)

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @doct0r-furcation! Everything is looking good on testing for all screen sizes.

@jimchamp jimchamp merged commit ba05bb3 into internetarchive:master Aug 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants