-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Improved Card Component for Community Lists #11104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Card Component for Community Lists #11104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
| <i>Community List</i> | ||
| <div class="list-follow-card__bottom-community"> | ||
| <div class="list-follow-card__user"> | ||
| <img src="/static/images/openlibrary-128x128.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative. This is a problem for people using screen readers.
|
@krishnaGauss, this is on the right track! Great work. A few suggestions
|
|
@mekarpeles i guess i'll just add alt-text then? Since the class is the same as user, only the community label is a bit different to stand out... |
ea1a2ba to
6a90646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11104 +/- ##
==========================================
+ Coverage 17.14% 17.85% +0.71%
==========================================
Files 91 92 +1
Lines 4981 5096 +115
Branches 867 887 +20
==========================================
+ Hits 854 910 +56
- Misses 3588 3639 +51
- Partials 539 547 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…hnaGauss/openlibrary into 11075/design/community-lists-render
Closes #11075
Fixes the Lists card component bottom section to render
Community Lists.Technical
Community Liststo$_("Community List")to support language changes.Testing
Screenshot
Stakeholders
@mekarpeles