Skip to content

Conversation

@krishnaGauss
Copy link
Contributor

Closes #11075

Fixes the Lists card component bottom section to render Community Lists.

Technical

  • Added ** OpenLibrary ** logo for Community Lists.
  • Improved the styling for Community Lists.
  • Changed Community Lists to $_("Community List") to support language changes.

Testing

  • One can move to any book section and scroll down to Lists.
  • Can then check for community lists.

Screenshot

473806953-c9e2c42c-e942-493e-8389-9a4d6c3917da

Stakeholders

@mekarpeles

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<i>Community List</i>
<div class="list-follow-card__bottom-community">
<div class="list-follow-card__user">
<img src="/static/images/openlibrary-128x128.png" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

@mekarpeles
Copy link
Member

@krishnaGauss, this is on the right track! Great work. A few suggestions

  1. alt-text
  2. Can we style "Community Lists" the same (e.g. same class) as a username?

@krishnaGauss
Copy link
Contributor Author

@mekarpeles i guess i'll just add alt-text then? Since the class is the same as user, only the community label is a bit different to stand out...

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Aug 6, 2025
@krishnaGauss krishnaGauss force-pushed the 11075/design/community-lists-render branch from ea1a2ba to 6a90646 Compare August 6, 2025 08:48
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.85%. Comparing base (e027195) to head (f0f3d7f).
⚠️ Report is 406 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11104      +/-   ##
==========================================
+ Coverage   17.14%   17.85%   +0.71%     
==========================================
  Files          91       92       +1     
  Lines        4981     5096     +115     
  Branches      867      887      +20     
==========================================
+ Hits          854      910      +56     
- Misses       3588     3639      +51     
- Partials      539      547       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…hnaGauss/openlibrary into 11075/design/community-lists-render
@mekarpeles mekarpeles merged commit 6e50348 into internetarchive:master Aug 6, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Response Issues which require feedback from lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improving the styling for Card Components (Post Community List fix)

3 participants