fix: improve homepage accessibility for screen readers #11355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves homepage accessibility by strengthening semantic structure and clarifying assistive technology cues.
- Replace a generic container with a semantic main landmark for primary content.
- Add empty alt text to decorative images in onboarding and category carousels.
- Adjust heading hierarchy and mark the search form as a search landmark.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| openlibrary/templates/site/body.html | Wrap primary content in a main element to provide a landmark. |
| openlibrary/templates/lib/nav_head.html | Add role="search" to the search form for better landmark navigation. |
| openlibrary/templates/home/onboarding_card.html | Add alt="" to onboarding images to mark them decorative. |
| openlibrary/templates/home/categories.html | Set category icons’ alt="" to treat them as presentational. |
| openlibrary/templates/home/about.html | Improve heading hierarchy: mission is a paragraph; blog posts heading remains an h3. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cdrini
approved these changes
Oct 15, 2025
Collaborator
cdrini
left a comment
There was a problem hiding this comment.
Aweeesome, thank you @akramcodez ! Confirmed with a screenreader, working much better now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11353
Technical
<div id="test-body-mobile">to<main>element for landmark navigationalt=""to onboarding carousel images (presentational)<h3>to<p>element<h3>for proper heading hierarchyrole="search"to search formalt=""on browse by subject carousel images (presentational)