Fix BWB provider error #11452
Merged
Fix BWB provider error #11452
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
P0 since blocking the deploy. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to fix an error in the BetterWorldBooksProvider.get_identifiers method. The change modifies how ISBN identifiers are collected and returned, addressing what appears to be a TypeError from the original implementation while also introducing new conditional logic that only returns identifiers for books present in the BWB acquisitions.
Key Changes
- Modified
get_identifiersmethod to use chainedoroperators instead of list concatenation - Added conditional check to only return ISBNs for books present in
bwb_acquisitions - Changed from returning combined ISBN lists to returning only the first found ISBN type
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix to an error happening on testing, likely due to #11379 .
https://testing.openlibrary.org/works/OL20834335W/Progressive_Web_Apps_with_Angular?edition=key%3A/books/OL28205778M
Technical
Testing
Screenshot
Stakeholders