-
Notifications
You must be signed in to change notification settings - Fork 112
feat: add form locking mechanism and share edit permission
#2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f9b7c67 to
fc37acb
Compare
fc37acb to
a3198a4
Compare
18c3220 to
5c16474
Compare
77df1d9 to
59282d7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2737 +/- ##
============================================
- Coverage 45.48% 44.12% -1.37%
- Complexity 987 1022 +35
============================================
Files 79 80 +1
Lines 3586 3683 +97
============================================
- Hits 1631 1625 -6
- Misses 1955 2058 +103 🚀 New features to boost your workflow:
|
986e8f9 to
a342623
Compare
db61925 to
5b0d4a6
Compare
a00eca1 to
aaff8fa
Compare
ff55376 to
0194dbf
Compare
0194dbf to
63471e4
Compare
- Implemented form locking functionality to prevent concurrent edits. - Updated API responses to include `lockedBy` and `lockedUntil` fields. - Enhanced permission checks to ensure only the form owner can transfer ownership. - Revised documentation to reflect changes in form data structure and API behavior. Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
…for archiving, locking, and ownership transfer Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
d5e9733 to
aa8eca7
Compare
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally makes sense and looks good!
I would personally have it inverted meaning using lockedSince instead of lockedUntil as then we can change the locking time easier on updates.
But makes not really a difference.
lockedByandlockedUntiltogetFormandgetFormseditpermission to shares in frontend (backend already handles it correctly)What should someone with edit permissions be able to do?
closedarchivedpermitAllUsers,showToAllUsers)