-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(IURLGenerator): Allow markdown parenthesis in URL_REGEX_NO_MODIFIERS #49334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(IURLGenerator): Allow markdown parenthesis in URL_REGEX_NO_MODIFIERS #49334
Conversation
Signed-off-by: provokateurin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs extensive tests added to not break cases like:
Please check the website (https://nextcloud.com/)
Please check the website https://nextcloud.com/wikipedia_(has-braces)
And the likes. It was a long fight with usability of most users. So we really prefer broken previews over broken UX of normal users posting behaviour
|
If a URL has special characters, they must be encoded, no? I don't see how even the browser could work with it, if the URL is not encoded. |
Summary
Related to nextcloud/spreed#13756.
Apparently the web UI doesn't use this regex but a hardcoded one, but I fixed it there as well: nextcloud-libraries/nextcloud-vue#6224
Clients should be using this regex, so it also needs to work with the parenthesis from embedded markdown links.
Checklist