Skip to content

Conversation

@erjer-odoo
Copy link
Contributor

@erjer-odoo erjer-odoo commented Jan 7, 2026

While updating tutorials around removal strategies and expiration dates, I noticed that the documentation around reassigning lots and serial numbers was outdated as of version 18.2. This PR completely rewrites the content, bringing it up to date with 18.2, and updates and adds screenshots.

This saas-18.2 PR should not be FWP past saas-18.4.

@erjer-odoo erjer-odoo requested a review from larm-odoo January 7, 2026 21:39
@erjer-odoo erjer-odoo self-assigned this Jan 7, 2026
@erjer-odoo erjer-odoo added the 5 label Jan 7, 2026
@robodoo
Copy link
Collaborator

robodoo commented Jan 7, 2026

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team January 7, 2026 21:42
Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erjer-odoo - this is a great doc and a complex topic IMO. I left a bunch of suggestions, mostly optional. I was having issues following along in my runbot isnce I was getting errors, so I'd like to re-check this after you make changes, and check against a different one and make sure I can do all the steps in order.

I do have one suggesiton, and I don't know if it's doable or if you have a better idea - but I think there is some value in explaiing the difference between adding lot numbers and serial numbers. SN's are usually unique, so you wouldalways have a quantity of one ofr each one, whereas lots are usually a bunch in one lot. Youdon't need to change the sections ot be 'add lot numbers' and 'add serisl numbers' but I think it woudl be helpful to have a detailed example admonition for each one. Then you can give the example of : A company has 5 different lots of eggs, each with 100 dozen in each. To set this, first..." Then for a serial numebr you can say "A company has custom desks each with unique serial numbers. To adjust the inventory, first..." Just a suggestion though! Tag me for another look when you're done - but looking good!!

@erjer-odoo erjer-odoo force-pushed the saas-18.2-inventory-reassign-lot-serial-numbers-erjer branch from c3c64de to 1bb4234 Compare January 9, 2026 21:47
@erjer-odoo erjer-odoo requested a review from larm-odoo January 9, 2026 21:48
@erjer-odoo
Copy link
Contributor Author

Hi @larm-odoo ! Thank you for your review!

I left some comments open either to let you see my answers to clarifying questions you had, or to verify that I'm on the right path. That way, if you want to continue the conversation about those, those comments are still open and visible. :)

For the record, I had already attempted to address some of your concerns by adding an important block about when tracking should be enabled for this process to work -- not sure if you saw it, but it's before the first subsection. Hopefully it gets at what you might have been looking for.

I've re-requested a review. Feel free to take a look at it when you get a chance, and I'll do what I can to update the document accordingly. Thank you so much for your thorough reviews -- my docs always end up so much better for it!

Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erjer-odoo - I cannot believe I missed a few htings and didn't realize you addressed my quesitons in the begining! I swear, I read it twice but still didn't "get it". Now that I understand what the doc is actually telling me to do, I can read it thorugh correctly, and I approve it - great job!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @erjer-odoo !

Since the fwp-ing is a little special, I'll delegate the merge to you (: Let me know if you have questions about the forward porting process! (:

@robodoo delegate+

Co-authored-by: larm-odoo <[email protected]>

Co-authored-by: larm-odoo <[email protected]>
Co-authored-by: Felicia Kuan <[email protected]>
@erjer-odoo erjer-odoo force-pushed the saas-18.2-inventory-reassign-lot-serial-numbers-erjer branch from e28f1c2 to 7541b37 Compare January 12, 2026 23:19
@erjer-odoo erjer-odoo added 3 and removed 5 labels Jan 12, 2026
@erjer-odoo
Copy link
Contributor Author

@robodoo up to 19.0
@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Jan 12, 2026

Forward-porting to '19.0'.

robodoo pushed a commit that referenced this pull request Jan 12, 2026
closes #15916

Signed-off-by: Erin Jerison (erjer) <[email protected]>
Co-authored-by: larm-odoo <[email protected]>
Co-authored-by: larm-odoo <[email protected]>
Co-authored-by: Felicia Kuan <[email protected]>
@robodoo robodoo closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants