-
Notifications
You must be signed in to change notification settings - Fork 11k
[IMP] Inventory: Bringing reassign lot/serial numbers current #15916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Inventory: Bringing reassign lot/serial numbers current #15916
Conversation
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @erjer-odoo - this is a great doc and a complex topic IMO. I left a bunch of suggestions, mostly optional. I was having issues following along in my runbot isnce I was getting errors, so I'd like to re-check this after you make changes, and check against a different one and make sure I can do all the steps in order.
I do have one suggesiton, and I don't know if it's doable or if you have a better idea - but I think there is some value in explaiing the difference between adding lot numbers and serial numbers. SN's are usually unique, so you wouldalways have a quantity of one ofr each one, whereas lots are usually a bunch in one lot. Youdon't need to change the sections ot be 'add lot numbers' and 'add serisl numbers' but I think it woudl be helpful to have a detailed example admonition for each one. Then you can give the example of : A company has 5 different lots of eggs, each with 100 dozen in each. To set this, first..." Then for a serial numebr you can say "A company has custom desks each with unique serial numbers. To adjust the inventory, first..." Just a suggestion though! Tag me for another look when you're done - but looking good!!
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Show resolved
Hide resolved
c3c64de to
1bb4234
Compare
|
Hi @larm-odoo ! Thank you for your review! I left some comments open either to let you see my answers to clarifying questions you had, or to verify that I'm on the right path. That way, if you want to continue the conversation about those, those comments are still open and visible. :) For the record, I had already attempted to address some of your concerns by adding an important block about when tracking should be enabled for this process to work -- not sure if you saw it, but it's before the first subsection. Hopefully it gets at what you might have been looking for. I've re-requested a review. Feel free to take a look at it when you get a chance, and I'll do what I can to update the document accordingly. Thank you so much for your thorough reviews -- my docs always end up so much better for it! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @erjer-odoo - I cannot believe I missed a few htings and didn't realize you addressed my quesitons in the begining! I swear, I read it twice but still didn't "get it". Now that I understand what the doc is actually telling me to do, I can read it thorugh correctly, and I approve it - great job!
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Show resolved
Hide resolved
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @erjer-odoo !
Since the fwp-ing is a little special, I'll delegate the merge to you (: Let me know if you have questions about the forward porting process! (:
@robodoo delegate+
...nt/applications/inventory_and_mrp/inventory/product_management/product_tracking/reassign.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: larm-odoo <[email protected]> Co-authored-by: larm-odoo <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>
e28f1c2 to
7541b37
Compare
|
Forward-porting to '19.0'. |
closes #15916 Signed-off-by: Erin Jerison (erjer) <[email protected]> Co-authored-by: larm-odoo <[email protected]> Co-authored-by: larm-odoo <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>

While updating tutorials around removal strategies and expiration dates, I noticed that the documentation around reassigning lots and serial numbers was outdated as of version 18.2. This PR completely rewrites the content, bringing it up to date with 18.2, and updates and adds screenshots.
This saas-18.2 PR should not be FWP past saas-18.4.