Skip to content

Work-around oc delete issues in newapp tests #19618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adambkaplan wants to merge 1 commit into from
Closed

Work-around oc delete issues in newapp tests #19618

adambkaplan wants to merge 1 commit into from

Conversation

@adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented May 3, 2018

  • Addresses timing issues with reap/GC on build objects
  • Explicit deletes for services, dc, bc, and imagestreams

Fixes #19588

@adambkaplan
Work-around oc delete issues in newapp tests
130f430 
* Addresses timing issues with reap/GC on build objects
* Explicit deletes for services, dc, bc, and imagestreams

Fixes openshift#19588
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 3, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adambkaplan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: soltysh

Assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 3, 2018
@adambkaplan
Copy link
Contributor Author

adambkaplan commented May 3, 2018

/assign @soltysh

@adambkaplan
Copy link
Contributor Author

adambkaplan commented May 4, 2018

/retest

1 similar comment
@adambkaplan
Copy link
Contributor Author

adambkaplan commented May 4, 2018

/retest

@soltysh
Copy link
Contributor

soltysh commented May 8, 2018

/hold
all should pick up the necessary resources, this seems weird.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2018
@deads2k
Copy link
Contributor

deads2k commented May 8, 2018

/hold
all should pick up the necessary resources, this seems weird.

Yeah, looks like you're just looking for a wait until you don't get any resources back, right?

@soltysh
Copy link
Contributor

soltysh commented May 8, 2018

This was fixed in #19616
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@soltysh soltysh

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adambkaplan @openshift-ci-robot @soltysh @deads2k