Skip to content

fix: issue of uri_resolver_aggregator not resolving uri from static resolver #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Niraj-Kamdar merged 2 commits into from
Apr 13, 2023
Merged

fix: issue of uri_resolver_aggregator not resolving uri from static resolver #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5bb23b
fix: issue of uri_resolver_aggregator not resolving uri from static r…
Niraj-Kamdar Apr 13, 2023
24b482e
chore: fix linting issues
Niraj-Kamdar Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...wrap-uri-resolvers/polywrap_uri_resolvers/resolvers/aggregator/uri_resolver_aggregator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
"""This module contains the UriResolverAggregator Resolver."""
from typing import List, Optional
from typing import List, Optional, cast

from polywrap_core import (
InvokerClient,
IUriResolutionContext,
Uri,
UriPackage,
UriPackageOrWrapper,
UriResolver,
UriWrapper,
)

from ...types import UriResolutionStep
Expand Down Expand Up @@ -68,15 +70,17 @@ async def try_resolve_uri(
uri_package_or_wrapper = await resolver.try_resolve_uri(
uri, client, sub_context
)
if uri_package_or_wrapper != uri:
if uri_package_or_wrapper != uri or isinstance(
uri_package_or_wrapper, (UriPackage, UriWrapper)
):
step = UriResolutionStep(
source_uri=uri,
result=uri_package_or_wrapper,
result=cast(UriPackageOrWrapper, uri_package_or_wrapper),
sub_history=sub_context.get_history(),
description=self.step_description,
)
resolution_context.track_step(step)
return uri_package_or_wrapper
return cast(UriPackageOrWrapper, uri_package_or_wrapper)

step = UriResolutionStep(
source_uri=uri,
Expand Down