Patch Release 10.8.1 #554
Merged
Patch Release 10.8.1 #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run script/check-versions after testing
shawnbot
approved these changes
Aug 2, 2018
Contributor
shawnbot
left a comment
There was a problem hiding this comment.
This looks good to go; just need to add the version check update to the changelog, right?
Contributor
Author
|
@shawnbot oh yep! I just need to push that up! |
added 2 commits
August 2, 2018 15:29
…patch-release-10.8.1
jonrohan
approved these changes
Aug 2, 2018
This was referenced Dec 18, 2022
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a patch release to fix an outdated peer dependency in
primer-popoverandprimer-marketing-buttons. I've also updated the releasing docs to make sure this doesn't happen again 😬@shawnbot also added the version check to CI so that our builds will fail if there is a version mismatch 🎉
/cc @primer/ds-core