Add query parameters to ServerRequest
#180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
reviewed
Apr 27, 2017
README.md
Outdated
| ``` | ||
|
|
||
| The response in the above example will return a response body with a link. | ||
| The URL contains query paramter `foo` with the value `bar`. |
Member
There was a problem hiding this comment.
The URL contains the query parameter
clue
reviewed
Apr 27, 2017
README.md
Outdated
| $body .= '<a href="/?foo=bar">to use query parameter in your request</a>'; | ||
|
|
||
| if (isset($queryParams['foo'])) { | ||
| $body = 'The value of "foo" is: ' . $queryParams['foo']; |
Member
There was a problem hiding this comment.
Maybe we should add a note about it being a XSS vector, just to educate 😝
fc63393 to
55ce05f
Compare
Contributor
|
Any chance to get this in? Looks straight forward? |
jsor
approved these changes
May 5, 2017
clue
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the query parameters of the URI will be added to the
ServerRequest.Closes #178