-
Notifications
You must be signed in to change notification settings - Fork 22
feat: migrate to v1.0.0 for package manager compliance (atomic Go module migration) #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vxfemboy
wants to merge
9
commits into
vmfunc:main
Choose a base branch
from
vxfemboy:migration/v1.0.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update go.mod module declaration - Update imports in main entry points (sif.go, sif_test.go, cmd/sif/main.go) Part 1/8 of v1.0.0 migration for package manager compliance. Related: vmfunc#57
- Update imports in scan.go, cloudstorage.go, cms.go, dirlist.go, dnslist.go - Update runtime data URLs to vmfunc/sif-runtime Part 2/8 of v1.0.0 migration. Related: vmfunc#57
- Update imports in dork.go, git.go, headers.go, lfi.go, nuclei.go - Update runtime data URLs to vmfunc/sif-runtime Part 3/8 of v1.0.0 migration. Related: vmfunc#57
- Update imports in ports.go, shodan.go, sql.go, subdomaintakeover.go, whois.go - Update runtime data URLs to vmfunc/sif-runtime Part 4/8 of v1.0.0 migration. Related: vmfunc#57
- Update imports in detect.go, detect_test.go - Update imports in framework detectors (backend, cms, frontend) Part 5/8 of v1.0.0 migration. Related: vmfunc#57
- Update imports in meta detector, js/scan, modules/loader - Update imports in nuclei/format, styles Part 6/8 of v1.0.0 migration. Related: vmfunc#57
- Update README.md contributor links (lunchcat → vmfunc) - Update Makefile repo URL, remove lunchcat.dev - Update .all-contributorsrc projectOwner - Add comprehensive CHANGELOG.md - Standardize Discord links to discord.com/invite/sifcli Enables package manager compliance for Void Linux, Debian, Fedora, Arch. Part 8/8 of v1.0.0 migration - COMPLETE. Closes vmfunc#57 Related: vmfunc#50
dbb598f to
2566459
Compare
Author
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

I understand the preference for PRs with ≤5 files modified. However, this Go module path migration must be atomic to prevent CI failures and build breakage.
Technical Constraint: Go Module Migration Must Be Atomic
When changing a Go module path in
go.mod, all import statements across the entire codebase must be updated simultaneously in the same commit/PR. Here's why:If split into multiple PRs:
go.mod→ All subsequent PRs fail CI (can't import old path)The only working approach: Change
go.mod+ all imports in a single atomic PR.What We're Doing About the File Count
To minimize impact, we're splitting independent changes into separate PRs:
Makefile,.all-contributorsrc,README.mdcontributor linksCONTRIBUTING.md,docs/README.mdThis PR only contains the atomic Go module migration that cannot be split without breaking the build.