Skip to content

Conversation

@vxfemboy
Copy link

@vxfemboy vxfemboy commented Jan 6, 2026

⚠️ Why This PR Exceeds the 5-File Limit

I understand the preference for PRs with ≤5 files modified. However, this Go module path migration must be atomic to prevent CI failures and build breakage.

Technical Constraint: Go Module Migration Must Be Atomic

When changing a Go module path in go.mod, all import statements across the entire codebase must be updated simultaneously in the same commit/PR. Here's why:

// In go.mod
module github.com/vmfunc/sif  // ← If we change this...

// Then ALL of these break immediately:
import "github.com/dropalldatabases/sif/internal/config"  // ❌ Won't compile
import "github.com/dropalldatabases/sif/internal/scan"    // ❌ Won't compile

If split into multiple PRs:

  1. PR Base scanning doesn't occur even when --noscan is present #1 changes go.modAll subsequent PRs fail CI (can't import old path)
  2. PR 🎀 feat: Shodan Integration #2 tries to fix imports → Can't merge until PR Base scanning doesn't occur even when --noscan is present #1 merges (circular dependency)
  3. Main branch is broken between merges
  4. All CI checks fail until every PR merges

The only working approach: Change go.mod + all imports in a single atomic PR.

What We're Doing About the File Count

To minimize impact, we're splitting independent changes into separate PRs:

  • Can be separate PR: Domain fixes (remove references to lunchcat domain #50) - Makefile, .all-contributorsrc, README.md contributor links
  • Can be separate PR: Discord link standardization - CONTRIBUTING.md, docs/README.md
  • ⚠️ MUST be atomic: Module path migration - 36+ files (this PR)

This PR only contains the atomic Go module migration that cannot be split without breaking the build.

@vxfemboy vxfemboy marked this pull request as draft January 6, 2026 23:08
- Update go.mod module declaration
- Update imports in main entry points (sif.go, sif_test.go, cmd/sif/main.go)

Part 1/8 of v1.0.0 migration for package manager compliance.
Related: vmfunc#57
- Update imports in scan.go, cloudstorage.go, cms.go, dirlist.go, dnslist.go
- Update runtime data URLs to vmfunc/sif-runtime

Part 2/8 of v1.0.0 migration.
Related: vmfunc#57
- Update imports in dork.go, git.go, headers.go, lfi.go, nuclei.go
- Update runtime data URLs to vmfunc/sif-runtime

Part 3/8 of v1.0.0 migration.
Related: vmfunc#57
- Update imports in ports.go, shodan.go, sql.go, subdomaintakeover.go, whois.go
- Update runtime data URLs to vmfunc/sif-runtime

Part 4/8 of v1.0.0 migration.
Related: vmfunc#57
- Update imports in detect.go, detect_test.go
- Update imports in framework detectors (backend, cms, frontend)

Part 5/8 of v1.0.0 migration.
Related: vmfunc#57
- Update imports in meta detector, js/scan, modules/loader
- Update imports in nuclei/format, styles

Part 6/8 of v1.0.0 migration.
Related: vmfunc#57
- Update clone URLs in docs/ to vmfunc/sif
- Update CONTRIBUTING.md repository references and Discord link
- Update API mode flag description (remove lunchcat reference)

Part 7/8 of v1.0.0 migration.
Related: vmfunc#57, vmfunc#50
@vxfemboy vxfemboy changed the title migration feat: migrate to v1.0.0 for package manager compliance (atomic Go module migration) Jan 7, 2026
- Update README.md contributor links (lunchcat → vmfunc)
- Update Makefile repo URL, remove lunchcat.dev
- Update .all-contributorsrc projectOwner
- Add comprehensive CHANGELOG.md
- Standardize Discord links to discord.com/invite/sifcli

Enables package manager compliance for Void Linux, Debian, Fedora, Arch.

Part 8/8 of v1.0.0 migration - COMPLETE.

Closes vmfunc#57
Related: vmfunc#50
@vxfemboy vxfemboy marked this pull request as ready for review January 7, 2026 00:04
@vxfemboy
Copy link
Author

vxfemboy commented Jan 7, 2026

image

@vmfunc vmfunc added the blocked waiting for changes by author label Jan 12, 2026
@vmfunc
Copy link
Owner

vmfunc commented Jan 12, 2026

blocked by #63, #64 and #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked waiting for changes by author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants