-
Notifications
You must be signed in to change notification settings - Fork 25
Default to adding idempotecy-key to audit-logs/events if not present, added in retryability logic to endpoints #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
swaroopAkkineniWorkos
wants to merge
27
commits into
main
Choose a base branch
from
ENT-3983-python-idempotency-retry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1e3e7ef
stuff
swaroopAkkineniWorkos 7823022
retry
swaroopAkkineniWorkos e3a12d7
more cleanup
swaroopAkkineniWorkos 9d2dae2
moar cleanup
swaroopAkkineniWorkos 311d4ca
moar tests
swaroopAkkineniWorkos 922ffe7
stuff
swaroopAkkineniWorkos 35a2706
cleanup
swaroopAkkineniWorkos 5611ce7
stuff
swaroopAkkineniWorkos 145d24c
lol
swaroopAkkineniWorkos a8854b5
lol
swaroopAkkineniWorkos 8fd6a5d
moar
swaroopAkkineniWorkos 53a706b
Refactor retry logic method naming for clarity
swaroopAkkineniWorkos 479ced1
Fix Black formatting for HTTP client retry implementation
swaroopAkkineniWorkos 2bb414f
Align async retry tests with sync test suite
swaroopAkkineniWorkos b1695ec
Apply black formatting to test_http_client_retry.py
swaroopAkkineniWorkos 81bab32
remove
swaroopAkkineniWorkos 7aa9142
remove
swaroopAkkineniWorkos c647324
moar
swaroopAkkineniWorkos adfcb80
cleanup
swaroopAkkineniWorkos 6df9b7a
lint
swaroopAkkineniWorkos b10c8f0
sup
swaroopAkkineniWorkos 9b06353
moar tests
swaroopAkkineniWorkos f8745ca
moar tests
swaroopAkkineniWorkos 99e915f
sup
swaroopAkkineniWorkos 5f1d921
sup
swaroopAkkineniWorkos 434fe2f
Merge main into ENT-3983-python-idempotency-retry
gjtorikian 8c0fae0
lint
gjtorikian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| from workos.types.workos_model import WorkOSModel | ||
|
|
||
|
|
||
| class AuditLogEventResponse(WorkOSModel): | ||
| """Response from creating an audit log event.""" | ||
|
|
||
| success: bool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 for using dataclasses, this keeps the retry config abstracted away 👌