-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
remove unused author location code #11100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@RayBB I'm not really aware how the and on the So if it is being removed those should be updated too. |
|
@hornc once upon a time location was a field where people would put the geographic place that an author lives. For example: https://openlibrary.org/authors/OL487729A/Fernando_Telletxea?_compare=Compare&b=9&a=8&m=diff I've moved many of those to the description (and deleted others like above). They weren't visible in any way. However, we still use the location field for redirects like this: You're right that we should update the schema and that page as well. Do you know if that /type/author page is used in any way? Like is it just documentation or is it somehow used by infogami or OL? If it's not used I suspect we probably should remove or or just redirect it to the schema you linked above. |
Those 785 records are broken and won't redirect as you can see by looking at the first one on the list: https://openlibrary.org/authors/OL1274282A It looks like the Wikidata bot corrupted that particular record, but I haven't checked any of the others:
There are almost half a million author records which have been merged (and many tens of thousands more which still need merging): gzcat ol_dump_redirects_2025-06-30.txt.gz | grep -E 'OL\d+A' | wc -l
479582 |
|
@tfmorris thanks for digging in. Drini knows about the bot corrupting some records and plans to fix it next week |
If you link that issue here, it'll save others the trouble of looking it up themselves. |
|
@cdrini thank you for understanding the request |
This code was always hidden and not displayed anyway.
We use the location field for redirects.
But it used to be that people could set a location (like Miami). That ended long ago. I think this is a relic from that era.
There are currently 2993 authors with a location field pr this duckdb query:
here they are:
authors_with_locations.csv
Interestingly only 785 include "/author/" in their location which is odd because I've probably merged that many authors alone.
Technical
Testing
Screenshot
Stakeholders